Skip to content

Bsneed/lifecycle rework #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Bsneed/lifecycle rework #411

wants to merge 3 commits into from

Conversation

@bsneed
Copy link
Contributor

@bsneed bsneed commented Nov 12, 2025

  • Refactor lifecycle handling for consistency between platforms.
  • Fixed condition where some lifecycle notifications happen prior to analytics SDK being initialized.
  • Added EventDebugger plugin to capture basic event data in the console.
  • WIP: Test coverage and suites are still in progress. Hand verification has passed though.

@codecov
Copy link

codecov bot commented Nov 12, 2025

Codecov Report

❌ Patch coverage is 14.51613% with 159 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.39%. Comparing base (f604cef) to head (bb3fa25).

Files with missing lines Patch % Lines
Sources/Segment/Plugins/EventDebugger.swift 0.00% 61 Missing ⚠️
Sources/Segment/SwiftUISupport.swift 0.00% 50 Missing ⚠️
Sources/Segment/Builtins.swift 33.33% 40 Missing ⚠️
...t/Plugins/Platforms/Mac/macOSLifecycleEvents.swift 46.66% 8 Missing ⚠️

❌ Your patch check has failed because the patch coverage (14.51%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #411      +/-   ##
==========================================
- Coverage   71.07%   68.39%   -2.69%     
==========================================
  Files          49       52       +3     
  Lines        4930     3828    -1102     
==========================================
- Hits         3504     2618     -886     
+ Misses       1426     1210     -216
Files with missing lines Coverage Δ
Sources/Segment/Analytics.swift 83.40% <ø> (-1.54%) ⬇️
...t/Plugins/Platforms/Mac/macOSLifecycleEvents.swift 24.32% <46.66%> (+21.88%) ⬆️
Sources/Segment/Builtins.swift 33.33% <33.33%> (ø)
Sources/Segment/SwiftUISupport.swift 0.00% <0.00%> (ø)
Sources/Segment/Plugins/EventDebugger.swift 0.00% <0.00%> (ø)

... and 47 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AntonTheDev
Copy link

AntonTheDev commented Nov 26, 2025

@bsneed was wondering, noticed recently that out team has not been getting "Application Installed" or "Application Updated" events. Started researching and step back to version 1.5.9 -> 1.9.1, and still can't get them to launch accordingly. could this be the fix?

p.s. using SceneDelegate in the app at the moment in the app

@AntonTheDev
Copy link

AntonTheDev commented Nov 26, 2025

@bsneed As a matter of fact I can confirm this fixes the application installed issue we've been having :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bsneed @AntonTheDev